Changeset 342

Show
Ignore:
Timestamp:
12/14/06 18:19:46 (2 years ago)
Author:
markku
Message:

Closes #197 and #198.

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • trunk/app/views/timeline/_display_event.rhtml

    r330 r342  
    1111      <%= 
    1212      case event.event_type 
    13        when WorkOrderEvent.TYPES[:CREATED] 
    14          _('Created by %s', event.creator ? event.creator.login_and_name : _('Unknown')) 
    15        when WorkOrderEvent.TYPES[:CLOSED] 
    16          _('Closed by %s', event.creator ? event.creator.login_and_name : _('Unknown')) 
    17        when WorkOrderEvent.TYPES[:ASSIGNED] 
    18          _("Assigned to %s by %s",  event.work_order_owner ? event.work_order_owner.login_and_name : _('Unknown'),  event.creator ? event.creator.login_and_name : _('Unknown')) 
    19        when WorkOrderEvent.TYPES[:ACCEPTED] 
    20          _('Accepted by %s', event.creator ? event.creator.login_and_name : _('Unknown')) 
    21        when WorkOrderEvent.TYPES[:REOPENED] 
    22          _('Reopened by %s', event.creator ? event.creator.login_and_name : _('Unknown')) 
    23       end  
     13        when WorkOrderEvent.TYPES[:CREATED] 
     14          _('Created by %s', event.creator ? event.creator.login_and_name : _('Unknown')) 
     15        when WorkOrderEvent.TYPES[:CLOSED] 
     16          _('Closed by %s', event.creator ? event.creator.login_and_name : _('Unknown')) 
     17        when WorkOrderEvent.TYPES[:ASSIGNED] 
     18          _("Assigned to %s by %s",  event.work_order_owner ? event.work_order_owner.login_and_name : _('Unknown'),  event.creator ? event.creator.login_and_name : _('Unknown')) 
     19        when WorkOrderEvent.TYPES[:ACCEPTED] 
     20          _('Accepted by %s', event.creator ? event.creator.login_and_name : _('Unknown')) 
     21        when WorkOrderEvent.TYPES[:REOPENED] 
     22          _('Reopened by %s', event.creator ? event.creator.login_and_name : _('Unknown')) 
     23      end 
    2424      -%> 
    2525    </span> 
     
    3030 
    3131    <span class="created"> 
    32       <%=  
     32      <%= 
    3333      case event.event_type 
    34         when ReportEvent.TYPES[:CREATED]  
    35          _('Created by %s', event.creator ? event.creator.login_and_name : _('Unknown')) 
    36        when ReportEvent.TYPES[:MODIFIED] 
    37           _('Modified by %s', event.creator ? event.creator.login_and_name : _('Unknown'))  
     34        when ReportEvent.TYPES[:CREATED] 
     35          _('Created by %s', event.creator ? event.creator.login_and_name : _('Unknown')) 
     36        when ReportEvent.TYPES[:MODIFIED] 
     37          _('Modified by %s', event.creator ? event.creator.login_and_name : _('Unknown')) 
    3838      end 
    3939      -%> 
    4040    </span> 
    41    
     41 
    4242  <% when 'AttachmentEvent' -%> 
    4343    <%= link_to_asset(event.attachment.asset) if show_asset_link %> 
     
    4545 
    4646    <span class="created"> 
    47       <%=  
     47      <%= 
    4848      case event.event_type 
    4949      when AttachmentEvent.TYPES[:CREATED] 
    5050        _('Uploaded by %s', event.creator ? event.creator.login_and_name : _('Unknown')) 
    51       end  
     51      end 
    5252      -%> 
    5353    </span> 
     
    5656</dt> 
    5757 
    58 <% if event.comment_text and !event.comment_text == "" -%>  
     58<% if event.comment_text and event.comment_text != '' -%> 
    5959  <dd class="timeline_event_comment"> 
    6060    <%= h(event.comment_text) %> 
  • trunk/db/migrate/001_initial.rb

    r203 r342  
    293293        t.column 'type', :string, :limit => 20, :default => '', :null => false 
    294294        t.column 'event_type', :integer, :default => 0, :null => false 
    295         t.column 'comment_text', :text, :default => '', :null => false 
     295        t.column 'comment_text', :text 
    296296        t.column 'created_by', :integer, :references => :users 
    297297        t.column 'created_at', :datetime 
     
    382382        t.column 'unread', :boolean, :default => true, :null => false 
    383383        t.column 'subject', :string, :limit => 80, :default => '', :null => false 
    384         t.column 'body', :text, :default => '', :null => false 
     384        t.column 'body', :text, :null => false 
    385385        t.column 'created_at', :datetime 
    386386      end 
  • trunk/test/functional/asset_field_controller_test.rb

    r329 r342  
    9797    assert_redirected_to :action => 'list', :id => @asset_type.id.to_s 
    9898    assert_raise(ActiveRecord::RecordNotFound) { AssetField.find field.id } 
    99     assert_nil flash[:notice] 
     99    assert_not_nil flash[:notice] 
    100100    assert_nil flash[:error] 
    101101  end 

© 2004-2007 Norfello Oy All Rights Reserved